vsoch reviewed a spack/spack pull request
Looks good! I tested: …
vsoch reviewed a opencontainers/wg-image-compatibility pull request
It looks great! …
vsoch reviewed a opencontainers/wg-image-compatibility pull request
Thank you for typing this up @mfranczy - it looks like a lot of work! And that said, I’m proud of our group! :tada: …
vsoch reviewed a flux-framework/flux-docs pull request
Seems good to me! But you mentioned the context it’s used in flux is different than fair share as a scheduling algorithm? How is that?…
vsoch reviewed a flux-framework/flux-sched pull request
Did a quick review!…
vsoch reviewed a flux-framework/flux-sched pull request
First I just want to give a :partying_face: for the hard work you’ve (@milroy and @cmisale) have put into this - getting a Go build integrated into autotools is no small thing, nor is making bindings with cgo! It’s really something to celebrate that this is ready for review! …
vsoch reviewed a flux-framework/flux-docs pull request
These are great! I think updating the (likely now deprecated) docs for coral2 is badly needed. I added a few suggestions for both - a lot of them tiny nits and you can pick and choose what you think is worth addressing. I don’t think I can be of much help reviewing the technical content (I’ve never used rabbits) but overall the description is very good. …
vsoch reviewed a oras-project/oras-www pull request
This looks good - my only suggestions: …
vsoch reviewed a mfem/web pull request
heeeey that’s me! cool! :partying_face: …
vsoch reviewed a buildsi/splice-experiment-results pull request
Nice! What is missing is a “ho to run this stuff” in a README, but maybe what I can do (tomorrow) is try to run everything and take notes) and I’ll ping you with questions. Does that worK? …
vsoch reviewed a singularityhub/singularity-hpc pull request
Here is some quick feedback!…
vsoch reviewed a LLNL/llnl.github.io pull request
Holly - love it! <3…
vsoch reviewed a conda-forge/oras-py-feedstock pull request
@wolfv I removed the docker-py dependency, and if I remember correctly I need to increment the version number too? …
vsoch reviewed a dyninst/dyninst pull request
:t-rex: …
vsoch reviewed a archspec/archspec pull request
Beautiful docs @alalazo ! Yes indeed a million times better to show the user how to use the library. …
vsoch reviewed a USRSE/usrse.github.io pull request
This LGTM @christophernhill - you noted you are waiting for a few more updates, ping me when it’s ready for another look or merge….
vsoch reviewed a spack/spack pull request
This is neat! perhaps if the glob hits more than one match there should be a warning / error print showing the user what is available?…
vsoch reviewed a USRSE/usrse.github.io pull request
This LGTM! But let’s get some more eyes on it to double check affiliations, etc….
vsoch reviewed a spack/spack pull request
```bash …
vsoch reviewed a spack/spack pull request
The one thing that is completely missing in the buildcache set of commands is: …
vsoch reviewed a USRSE/usrse.github.io pull request
Seems good to me! Definitely should get a few more eyes….
vsoch reviewed a spack/spack-infrastructure pull request
This is great! …
vsoch reviewed a USRSE/usrse.github.io pull request
You’ve addressed all my concerns!…
vsoch reviewed a snakemake/snakemake pull request
I think this should be ok! If there is an issue with snakeface it will pop up and we can address at that time….
vsoch reviewed a spack/spack-bot pull request
LGTM! I checked that this label does exist: …
vsoch reviewed a spack/spack pull request
A few quick questions! …
vsoch reviewed a singularityhub/singularity-hpc pull request
We are going to need to add a regex to avoid tags like: …
vsoch reviewed a supercontainers/containers-wg pull request
@reidpr this is beautiful feedback - it has me thinking that an entire idea / project is to go through this list and make some noise on the various OCI projects asking for clarification, and when it is found, to update the docs. I would say a related project to this is having the specs render into one cohesive RFC / documentation to digest (this was an issue brought upon this repo and I brought it up at the last OCI meeting). …
vsoch reviewed a urlstechie/urlchecker-python pull request
This is looking much better than the first round! I have some questions about the use case and the git hook file, and see my comments below….
vsoch reviewed a nipy/nipy.github.com pull request
This looks great! If you wanted to add links to Pydicom and Nibabl you could, but it’s not totally necessary….
vsoch reviewed a USRSE/usrse.github.io pull request
Pending a decision in https://github.com/USRSE/usrse.github.io/pull/428#discussion_r599135884, this LGTM! What a great, chock full of content newsletter! :tada: …
vsoch reviewed a USRSE/usrse.github.io pull request
Looks great! The title is a bit big for the event page, and we can address that with the website group. Note that I previewed on my phone and the
vsoch reviewed a USRSE/usrse.github.io pull request
LGTM! We probably want one more set of eyes since this is a newsletter….
vsoch reviewed a USRSE/usrse.github.io pull request
If checks now pass and the text is what the candidates provided, this LGTM!…
vsoch reviewed a USRSE/usrse.github.io pull request
LGTM! We probably want someone else from the steering committee to look over the content and A-OK it….
vsoch reviewed a USRSE/usrse.github.io pull request
Exciting!…
vsoch reviewed a snakemake/snakemake pull request
LGTM, @johanneskoester will have to give the final approval and merge….
vsoch reviewed a rust-bio/rust-htslib pull request
You’ve added my suggestion to mention the Dockerfile bases, so looks good to me (to the extent I can review that part)….